refactor: general cleanup of internals and documentation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/cleanup
branch
2 times, most recently
from
d4d0bd2
to
9842802
Compare
avik-pal
force-pushed
the
ap/cleanup
branch
2 times, most recently
from
c0ceae6
to
dc2a1f9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 91.84% 88.79% -3.06%
==========================================
Files 22 22
Lines 319 339 +20
==========================================
+ Hits 293 301 +8
- Misses 26 38 +12 ☔ View full report in Codecov by Sentry. |
avik-pal
force-pushed
the
ap/cleanup
branch
2 times, most recently
from
bbc4797
to
81ea8a4
Compare
avik-pal
force-pushed
the
ap/cleanup
branch
3 times, most recently
from
aa0491a
to
4c4cc3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
publicto specify that is public and what isn't@compactlayers are great but are mostly meant to be used in research codebases (see recent discussion in NeuralOperators.jl)Documentation
Documentation hosting going forward will be:
The reasoning is quite simple: currently making a breaking change in Lux creates a deadlock in docs building since Boltz needs to be updated before we can build the docs for lux and we can't release lux till docs build (since we have actual tests inside lux).