Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing the hydration error #571

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Try fixing the hydration error #571

merged 1 commit into from
Apr 5, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (b7a0b63) to head (0174d79).

❗ Current head 0174d79 differs from pull request most recent head 1562870. Consider uploading reports for the commit 1562870 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files          33       33           
  Lines        1728     1728           
=======================================
  Hits         1509     1509           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: 1562870 Previous: b7a0b63 Ratio
Dense(2 => 2)/cpu/forward/NamedTuple/(2, 128) 1991.7 ns 1999.7 ns 1.00
Dense(2 => 2)/cpu/forward/ComponentArray/(2, 128) 1568.8459119496856 ns 1566.2631578947369 ns 1.00
Dense(20 => 20)/cpu/forward/NamedTuple/(20, 128) 4996.428571428572 ns 4977.857142857143 ns 1.00
Dense(20 => 20)/cpu/forward/ComponentArray/(20, 128) 4818.285714285714 ns 4790.285714285715 ns 1.01
Conv((3, 3), 3 => 3)/cpu/forward/NamedTuple/(64, 64, 3, 128) 10187631 ns 10265756 ns 0.99
Conv((3, 3), 3 => 3)/cpu/forward/ComponentArray/(64, 64, 3, 128) 10203809 ns 10274883 ns 0.99
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 1) 22471721 ns 22632895 ns 0.99
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 16) 247851816.5 ns 245920571.5 ns 1.01
vgg16/cpu/forward/NamedTuple/(32, 32, 3, 64) 975061238.5 ns 972877624 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 1) 22395353 ns 22501168.5 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 16) 248229408 ns 247109687.5 ns 1.00
vgg16/cpu/forward/ComponentArray/(32, 32, 3, 64) 988374132 ns 987921217 ns 1.00
Conv((3, 3), 64 => 64)/cpu/forward/NamedTuple/(64, 64, 64, 128) 388874854 ns 373013391 ns 1.04
Conv((3, 3), 64 => 64)/cpu/forward/ComponentArray/(64, 64, 64, 128) 388501014.5 ns 369428453 ns 1.05
Conv((3, 3), 1 => 1)/cpu/forward/NamedTuple/(64, 64, 1, 128) 3856427 ns 3929480 ns 0.98
Conv((3, 3), 1 => 1)/cpu/forward/ComponentArray/(64, 64, 1, 128) 3862800.5 ns 3921774 ns 0.98
Dense(200 => 200)/cpu/forward/NamedTuple/(200, 128) 87574 ns 88845 ns 0.99
Dense(200 => 200)/cpu/forward/ComponentArray/(200, 128) 87183 ns 88585 ns 0.98
Conv((3, 3), 16 => 16)/cpu/forward/NamedTuple/(64, 64, 16, 128) 55467239 ns 56548766 ns 0.98
Conv((3, 3), 16 => 16)/cpu/forward/ComponentArray/(64, 64, 16, 128) 55604793 ns 56536433 ns 0.98
Dense(2000 => 2000)/cpu/forward/NamedTuple/(2000, 128) 6577361 ns 6485167 ns 1.01
Dense(2000 => 2000)/cpu/forward/ComponentArray/(2000, 128) 6591865.5 ns 6489996.5 ns 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@avik-pal avik-pal force-pushed the ap/stable_docs branch 2 times, most recently from 56ab87e to 0174d79 Compare April 5, 2024 02:43
@avik-pal avik-pal merged commit 849ec40 into main Apr 5, 2024
18 of 20 checks passed
@avik-pal avik-pal deleted the ap/stable_docs branch April 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant