Fix email FROM address to ensure it matches SMTP username
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the `FROM` address explicitly in the email-sending logic to match the configured `SMTP` username. This resolves issues where emails could be rejected by some mail servers due to a mismatch between the `FROM` address and the SMTP authenticated user.
📝 Coverage Report For Server Service
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Plant-it community!
What's new?
Thir PR fixes #289. I've implemented a fix to ensure that the
FROMaddress in our outgoing emails consistently matches the SMTP username. This change prevents issues with certain mail servers, that enforce strict checks on theFROMaddress and could reject our emails if there's a mismatch.Why is it important?
By explicitly setting the
FROMaddress to match the SMTP username, we ensure better email deliverability and improve the security of our email-sending process.How to Use?
No changes are required from the user side. The system will automatically use the correct
FROMaddress when sending emails, ensuring consistency and reliability.Cheers and happy planting! 🌿🌼