Introduce mass ratio #759
Open
Introduce mass ratio #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on this reminded me to at a certain time strip the copying of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small QOL improvement for binary runs.
In binary simulations, the mass ratio is important enough to have a history column available out of the box in mesa (and it required for plotting with
pgbinary).I understand the definition of
qis not universal, some fields usem1/m2, othersm2/m1(I chose the latter, typically the initially less massive over the initially more mass star). Hence I also implementedmin(m2/m1, m1/m2)as an "observational" mass ratio.