Feat/fix binding demo pipeline #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* forward declare DynamicSceneGraph where possible * rework NodeSymbol and hide eigen in new file * forward declare node attributes and some bounding boxes * forward declare mesh for bounding box * forward declare edge attributes and remove graph utilities from layer * split bindings into separate files * push edges towards derived layers * (wip) move traits and status * split layer prefix from types * minor cleanup of node * simplify eraseVertices * drop getPosition and eigen dep * drop node symbol include * remove typedef from * add missing bindings and fix compilation * add binary serialization for python layers * fix pytorch tests * remove commented code --------- Co-authored-by: Nathan Hughes <na26933@mit.edu>
* try adding python workflow * add test deps * install torch cpu only * fix url typo * add python badge --------- Co-authored-by: Nathan Hughes <na26933@mit.edu>
* switch feature vector to single precision * bump version
* add room colormap and cleanup ironbow * add conversion to hsv and hls * move colormaps to be functions * move colormaps to new file * add 150 class map and divergent map * clean up discrete colormaps * better sort colormaps * improve divergent docstring --------- Co-authored-by: Nathan Hughes <na26933@mit.edu>
* add khronos object bindings * make complex types readonly for safety for now
* correctly parse flat meshes from old versions * Update src/node_attributes.cpp Co-authored-by: Lukas Schmid <36043993+Schmluk@users.noreply.github.com> --------- Co-authored-by: Nathan Hughes <na26933@mit.edu> Co-authored-by: Lukas Schmid <36043993+Schmluk@users.noreply.github.com>
* add mesh append function * expand mesh python bindings * add default args for transform
* recombine bindings and use system pybind11 * fix binding ordering for default args * revert back to fetch content and reformat cmake * revert changes for avoiding newer pybind features * conditionally enable zmq implementation * clean up dependencies and other changes * switch to submodule * enable verbose build * add more status * revert debugging and use recursive clone * install git before checking out code
* add graph metadata object * skip networkx tests if not available * add python metadata interface * add node and edge metadata * use nodesymbol as primary arg type and add implicit conversion * add node and edge metadata bindings
nathanhhughes
force-pushed
the
develop
branch
2 times, most recently
from
0a8b0f2 to
0a8b29b
Compare
|
The issue that you're having is that you're visualizing a scene graph with 2D places ('P' is the prefix for 2D places, 'p' is the prefix for 3D places). I'm not opposed to the fix, but I'd rather solve it by providing defaults for unknown prefixes (i.e., by doing something like I'll add an actual review once this gets rebased on develop (sorry, had a backlog of issues / PRs to work through and needed to update the history for develop) Closes #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked
bindings_demo.pydoes not work now.So I'd like to do this PR to address that issue.