Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/remove_by_condition #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature/remove_by_condition #6

wants to merge 1 commit into from

Conversation

Schmluk
Copy link
Collaborator

@Schmluk Schmluk commented Jul 9, 2024 •
edited
Loading

  • Add a more elegant remove if interface for blocks (for some reason standard erase/remove did not work, but this should be fairly efficient, too)
  • Added utest

@Schmluk Schmluk requested a review from nathanhhughes July 9, 2024 07:29
nathanhhughes
nathanhhughes approved these changes Jul 9, 2024
View reviewed changes
Copy link

@nathanhhughes nathanhhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like the new API!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhhughes nathanhhughes nathanhhughes approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schmluk @nathanhhughes