Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mem): address memory leak related to the MemoryStore #1953

Merged
merged 4 commits into from
Jul 23, 2024
Merged

fix(mem): address memory leak related to the MemoryStore #1953

merged 4 commits into from
Jul 23, 2024

Conversation

Manangka
Copy link
Contributor

@Manangka Manangka commented Jul 16, 2024 •
edited
Loading

Fixes the memory leaks present in the PtrHashTableIterator and PtrHashTable

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Closed issue #xxxx
  • Referenced issue or pull request Memory Leaks #1943
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

@Manangka Manangka marked this pull request as ready for review July 17, 2024 13:08
@Manangka Manangka merged commit 0b493e0 into MODFLOW-USGS:develop Jul 23, 2024
20 checks passed
mjr-deltares
mjr-deltares reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@mjr-deltares mjr-deltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@wpbonelli wpbonelli mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjr-deltares mjr-deltares mjr-deltares left review comments

@lakmerol lakmerol lakmerol approved these changes

@jdhughes-usgs jdhughes-usgs Awaiting requested review from jdhughes-usgs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manangka @mjr-deltares @lakmerol