Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add surface heat fluxes to ocean climatology tasks #1012

Merged
merged 5 commits into from
Jul 16, 2024

Conversation

cbegeman
Copy link
Collaborator

Add surface heat fluxes to ocean climatology tasks

@xylar
Copy link
Collaborator

xylar commented Jul 10, 2024

@cbegeman, #1011 tuned out to be a mistake. I'll revert that as soon as I have time. In the meantime, maybe rebase this to exclude that change.

@cbegeman cbegeman force-pushed the enhance-ocean-climo-flux-task branch from 6bc5bf4 to 5c7a5b0 Compare July 10, 2024 22:10
@xylar
Copy link
Collaborator

xylar commented Jul 11, 2024

@cbegeman, #1011 tuned out to be a mistake. I'll revert that as soon as I have time. In the meantime, maybe rebase this to exclude that change.

This issue has been resolved on conda-forge and #1011 should now work fine. No need to rebase after all.

@cbegeman
Copy link
Collaborator Author

@xylar Thanks! I haven't yet been able to figure out why the heat and mass fluxes are ending up in the same subsection. I might be interpreting some of the gallery/group arguments to set_plot_info incorrectly. If you have time to take a look, that could be helpful.

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.cbegeman/analysis/20240626.HRr5-test11.chrysalis/climo_section_yrs1-10_latlon/ocean/index.html#global_ocnfluxclimo

@xylar
Copy link
Collaborator

xylar commented Jul 11, 2024

@cbegeman, I think the answer is just that there are only 2 levels of hierarchy -- gallery groups and galleries. Gallery groups also have a subtitle but that isn't another level of hierarchy. The're just additional information about the gallery group.

@cbegeman
Copy link
Collaborator Author

@xylar That's helpful. Thanks! I'll fix that up and update the docs and then I'll mark it ready for review.

@cbegeman cbegeman force-pushed the enhance-ocean-climo-flux-task branch from 5c7a5b0 to 4e941e5 Compare July 11, 2024 16:05
@cbegeman cbegeman marked this pull request as ready for review July 12, 2024 16:47
@cbegeman cbegeman requested a review from xylar July 12, 2024 16:49
@cbegeman cbegeman self-assigned this Jul 12, 2024
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a merge with #1013 (to fix an unrelated issue) and ran the test suite on Chrysalis. Results from the tests are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/enhance-ocean-climo-flux-task/

@cbegeman, another really great addition!

mpas_analysis/ocean/climatology_map_fluxes.py Outdated Show resolved Hide resolved
@cbegeman cbegeman merged commit 89fe749 into MPAS-Dev:develop Jul 16, 2024
0 of 5 checks passed
@cbegeman cbegeman deleted the enhance-ocean-climo-flux-task branch July 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants