Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjustments necessary to run open_ended_coders.py outside of Docker #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

18kimn
Copy link
Member

@18kimn 18kimn commented Oct 4, 2022

For some reason running docker compose up exits immediately with no error for the mpeds service, and running docker build . -f Dockerfile while in the mpeds subfolder also fails (although the error is taking a really long time to pop out now)

This PR just demonstrates the adjustments I made to get the script working outside of the docker environment; I'm not suggesting changes in any way, just putting this up to show what I did for docs purposes. Feel free to close after you've seen it --

Most of the edits had to do with migrating to python3, but there were some cases where the existing parser wanted to see a subject following a number, e.g. three hundred demonstrators, and would refuse to code three hundred on its own properly. I believe students were not aware of this requirement and in general articles don't always follow the structure of (number)(subject), so sometimes they would say "the number of demonstrators totaled three hundred" or any other form. So I removed the requirement for this token pattern

@alexhanna
Copy link
Member

Thanks. Tagging this with #15, because most of the changes are Python 3 ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants