Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs and tests #98

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Bugs and tests #98

wants to merge 19 commits into from

Conversation

DanielWang2029
Copy link
Collaborator

Added solution for the first issue and updated code for the second issue.

Added dw test
Added codes I wrote to understand test_that and vdiffr
Added svg plot for validation
Changed variable names in test
Added new test file, need to delete old test file
algorithm.r contains a function that returns the arrangment of icons given the canvas size and icon numbers.
Updated algorithm and part of makeContent function
Updated solution for the first issue
@DanielWang2029
Copy link
Collaborator Author

Update geom-bloc
Current version of the code works fine locally but there's no makeContent in cmd check.

@xiaoyingpu xiaoyingpu self-requested a review November 10, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants