Updated stylecop and threading analyzers

MUnique · Oct 20, 2023 · 6c5aa71 · 6c5aa71
1 parent 1a69fbf
commit 6c5aa71
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -3,11 +3,11 @@
 
     <ItemGroup Label="commom configuration code style.">
 
-        <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.4.27">
+        <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.7.30">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
         </PackageReference>
-        <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.435">
+        <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.507">
             <PrivateAssets>all</PrivateAssets>
             <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
         </PackageReference>

diff --git a/src/GameLogic/EnumerableExtensions.cs b/src/GameLogic/EnumerableExtensions.cs
@@ -29,6 +29,26 @@ public static void ForEach<T>(this IEnumerable<T> enumerable, Action<T> action)
         }
     }
 
+    /// <summary>
+    /// Executes the <paramref name="action"/> for each element of <paramref name="enumerable"/>.
+    /// </summary>
+    /// <typeparam name="T">The generic type of the enumerable.</typeparam>
+    /// <param name="enumerable">The enumerable.</param>
+    /// <param name="action">The action which should be executed for each element.</param>
+    /// <exception cref="System.ArgumentNullException">action.</exception>
+    public static async ValueTask ForEachAsync<T>(this IEnumerable<T> enumerable, Func<T, ValueTask> action)
+    {
+        if (action is null)
+        {
+            throw new ArgumentNullException(nameof(action));
+        }
+
+        foreach (var item in enumerable)
+        {
+            await action(item).ConfigureAwait(false);
+        }
+    }
+
     /// <summary>
     /// Returns the enumerable as list, by either casting it or creating it.
     /// </summary>

diff --git a/src/GameLogic/ObserverToWorldViewAdapter.cs b/src/GameLogic/ObserverToWorldViewAdapter.cs
@@ -147,7 +147,7 @@ public async ValueTask LocateablesOutOfScopeAsync(IEnumerable<ILocateable> oldOb
             oldItems.ForEach(item => this._observingObjects.Remove(item));
         }
 
-        oldItems.ForEach(item => item.RemoveObserverAsync(this._adaptee));
+        await oldItems.ForEachAsync(item => item.RemoveObserverAsync(this._adaptee)).ConfigureAwait(false);
 
         if (this._adaptee is IHasBucketInformation { NewBucket: null })
         {
@@ -208,7 +208,7 @@ public async ValueTask NewLocateablesInScopeAsync(IEnumerable<ILocateable> newOb
             await this._adaptee.InvokeViewPlugInAsync<IShowMoneyDropPlugIn>(p => p.ShowMoneyAsync(money.Id, false, money.Amount, money.Position)).ConfigureAwait(false);
         }
 
-        newItems.ForEach(item => item.AddObserverAsync(this._adaptee));
+        await newItems.ForEachAsync(item => item.AddObserverAsync(this._adaptee)).ConfigureAwait(false);
     }
 
     /// <summary>