Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop "where range" #675

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix rubocop "where range" #675

merged 1 commit into from
Aug 13, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Aug 13, 2024

I ran

bundle exec rubocop --autocorrect --disable-uncorrectable

which did not correct anything. After that, I ran

bundle exec rubocop -A

which corrected the three occurrences you see in this PR. Note that those corrections are unsafe due to this. Also see the Rails style guide here.

@Splines Splines added the dependencies Pull requests that update a dependency file label Aug 13, 2024
@Splines Splines self-assigned this Aug 13, 2024
@Splines Splines changed the base branch from main to dev August 13, 2024 17:52
@Splines Splines changed the title Fix rubocop where range Fix rubocop "where range" Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (dev@948e7ca). Learn more about missing BASE report.

Files Patch % Lines
app/models/medium.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #675   +/-   ##
======================================
  Coverage       ?   53.09%           
======================================
  Files          ?      153           
  Lines          ?     6614           
  Branches       ?        0           
======================================
  Hits           ?     3512           
  Misses         ?     3102           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit b2d587f into dev Aug 13, 2024
5 checks passed
@Splines Splines deleted the lint/rubocop-fixes branch August 13, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants