Fix annotation feedback not shown when share feature is disabled #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(should not be dependent on whether NEW annotations can be posted with the teacher or not)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #686 +/- ##
=======================================
Coverage 53.86% 53.86%
=======================================
Files 157 157
Lines 6645 6645
=======================================
Hits 3579 3579
Misses 3066 3066 ☔ View full report in Codecov by Sentry. |
fosterfarrell9
requested changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #668, we added an overview page for annotations (
/annotations). In the following scenario, the behavior was incoherent:In the annotation overview page, the annotation was then listed under the section for students annotations. However, if the teacher clicked on it, they were redirected to the feedback player but didn't see the annotation.
We came to the conclusion that we want the annotation to still be visible to the teacher in this case. This is justified since the student has deliberately clicked on "Make the annotation visible for the teacher" when creating the annotation, so the annotation should still be visible to the teacher regardless of the discussed lecture setting "allow students to share annotations with the teacher". In our interpretation, this option only refers to newly created annotations.
In this PR, we fix the incoherent behavior by still displaying shared annotations to the teacher (in the feedback player) even if the option in the lecture settings (see above) is disabled.