-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gemfile dependencies (bundle update
)
#688
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #688 +/- ##
=======================================
Coverage 53.86% 53.86%
=======================================
Files 157 157
Lines 6645 6645
=======================================
Hits 3579 3579
Misses 3066 3066 ☔ View full report in Codecov by Sentry. |
@fosterfarrell9 Good that we have tests: the update for the Instead of fixing the underlying problem during the update, I've pinned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I ran
bundle update
to update our dependencies according to our Gemfile (which I cleaned up recently in #680 and pinned Gems there). Might be worth checking out if there are new major versions for some gems (in a future PR).I also updated my local bundler version by executing
bundle update --bundler
. You can see this in the last line in theGemfile.lock
. The newest version is2.5.17
, released on August 1, 2024.TODO for myself & reviewers
We should probably not encounter any problems as we pinned the gems in Clean up Gemfile & pin all gems #680, such that they only undergo automatic minor version upgrades. There could still be a bad apple somewhere...