Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set locale to German in course specs #692

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Sep 8, 2024

As we are comparing to an array of values that contain German words like "Satz" or "Bsp.", we explicitly set the language to German here to avoid flaky tests in our pipeline due to the language of the user being chosen randomly.

This was originally discovered in this GitHub Actions run.

@Splines Splines added the tests Unit tests, integration tests etc. label Sep 8, 2024
@Splines Splines self-assigned this Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.86%. Comparing base (d48e369) to head (83e268d).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #692   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         157      157           
  Lines        6645     6645           
=======================================
  Hits         3579     3579           
  Misses       3066     3066           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit 78467de into dev Sep 8, 2024
5 checks passed
@Splines Splines deleted the fix/course-specs branch September 8, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Unit tests, integration tests etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants