Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TRAPI 1.5 critical validation errors regarding missing attributes #2

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

CaseyTa
Copy link
Contributor

@CaseyTa CaseyTa commented May 28, 2024

Fix TRAPI 1.5 critical validation errors regarding missing attributes in (KG) nodes and results node bindings and edge bindings

In TRAPI 1.5, attributes are now required and expected to be non-null but can have 0 items.

… in (KG) nodes and results node bindings and edge bindings
@CaseyTa
Copy link
Contributor Author

CaseyTa commented May 28, 2024

@micheldumontier @renayang2023 Could you please review? OpenPredict is failing integration with CQS after the call from Workflow Runner due to "critical" TRAPI validation errors in OpenPredict's response. Changes have been tested on my local deployment of OpenPredict.

@renayang2023
Copy link
Contributor

@micheldumontier @renayang2023 Could you please review? OpenPredict is failing integration with CQS after the call from Workflow Runner due to "critical" TRAPI validation errors in OpenPredict's response. Changes have been tested on my local deployment of OpenPredict.

@CaseyTa Thanks, Casey. I approved the changes. It seems that one workflow is still awaiting approval from those with write access to merge pull requests.

@micheldumontier micheldumontier merged commit e5bbddf into MaastrichtU-IDS:main Jun 3, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants