Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MadNLP] Fix the warning with SolverCore.solve! #403

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

amontoison
Copy link
Member

Fix the following warning:

   1 dependency had output during precompilation:
┌ MadNLP
│  ┌ Warning: Replacing docs for `SolverCore.solve! :: Union{}` in module `MadNLP`
│  └ @ Base.Docs docs/Docs.jl:243

@sshin23
Copy link
Member

sshin23 commented Jan 23, 2025

Yes, this was annoying. Thank you

@sshin23
Copy link
Member

sshin23 commented Jan 23, 2025

Would it make sense to import SolverCore.solve! and extend it?

@amontoison
Copy link
Member Author

amontoison commented Jan 23, 2025

Would it make sense to import SolverCore.solve! and extend it?

It's what we already do.
The issue was that a new docstring to the generic

function solve! end

was defined.

@sshin23
Copy link
Member

sshin23 commented Jan 23, 2025

I see. Thank you @amontoison !

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (2e301da) to head (0e4f330).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
src/KKT/KKTsystem.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #403       +/-   ##
===========================================
+ Coverage   70.17%   81.16%   +10.98%     
===========================================
  Files          45       42        -3     
  Lines        3943     3631      -312     
===========================================
+ Hits         2767     2947      +180     
+ Misses       1176      684      -492     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amontoison amontoison merged commit 230a047 into MadNLP:master Jan 23, 2025
8 of 10 checks passed
@amontoison amontoison deleted the fix_warning branch January 23, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants