Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store overwritten in example in docs #99

Open
kaustubhsridhar opened this issue May 23, 2021 · 0 comments
Open

store overwritten in example in docs #99

kaustubhsridhar opened this issue May 23, 2021 · 0 comments

Comments

@kaustubhsridhar
Copy link

kaustubhsridhar commented May 23, 2021

Hey,
The robustness library is pretty amazing. :)
I found a tiny error in your documentation for using robustness as a training library. (link)

The line 'store = store.Store(args.out_dir, args.exp_name)' overrides the name 'store'. This leads to an issue two lines later in 'schema = store.schema_from_dict(args_dict)' where the object store doesn't have a function called schema_from_dict but the library does.

Using cox.store.schema_from_dict fixes this issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant