Removed prototypejs from varien/product.js, varien/configurable.js and configurableswatches/swatches-product.js #68
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (const part of parts) { | ||
| if (part.includes('[')) { | ||
| const [name, index] = part.split('['); | ||
| const cleanIndex = parseInt(index.replace(']', '')); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 2 hours ago
To fix the problem, we need to ensure that all occurrences of the closing bracket (]) in the index string are replaced. This can be achieved by using a regular expression with the global flag (g). Specifically, we should replace index.replace(']', '') with index.replace(/\]/g, '').
| @@ -697,3 +697,3 @@ | ||
| const [name, index] = part.split('['); | ||
| const cleanIndex = parseInt(index.replace(']', '')); | ||
| const cleanIndex = parseInt(index.replace(/\]/g, '')); | ||
| value = value[name][cleanIndex]; |
|
Absolutely, I'll test first thing tomorrow. Also nice on making a new |
|
heheh good that you need that Template class :-) we can't really avoid having it :-) |
It seems to me that everything is working correctly but since I had 1000 problems with these files I'd like for somebody else to give them a test.
EDIT: product page should work with or without prototypejs
@justinbeaty would you review this? :-)