fix streamplot 3D default arrow size #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffreyer
reviewed
Dec 30, 2023
src/basic_recipes/streamplot.jl
Outdated
| @@ -28,7 +28,7 @@ See the function `Makie.streamplot_impl` for implementation details. | |||
| maxsteps = 500, | |||
| color = norm, | |||
|
|
|||
| arrow_size = 15, | |||
| arrow_size = nothing, | |||
There was a problem hiding this comment.
This should be automatic since we generally use that instead of nothing when things get derived later
There was a problem hiding this comment.
OK, I've changed nothing to automatic!
ffreyer
reviewed
Jan 1, 2024
src/basic_recipes/streamplot.jl
Outdated
Comment on lines
216
to
222
| if p.arrow_size[] === automatic | ||
| if N == 3 | ||
| arrow_size = 0.2 * minimum(p.limits[].widths) / minimum(p.gridsize[]) | ||
| else | ||
| arrow_size = 15 | ||
| end | ||
| end |
There was a problem hiding this comment.
This is missing an else branch which is why tests are failing. Might also be good to reorganize this so that p.arrow_size can change from automatic to some value. I.e. use arrow_size = map(p.arrow_size, p.limits, p.gridsize) do ....
ffreyer
approved these changes
Jan 8, 2024
|
@ffreyer thanks for cleaning this up. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3504
The default arrow size in 3D streamplot is set to
0.2 * minimum(limits.width) / minimum(gridsize)per @chakravala's comment in #3504.
The default arrow size in 2D streamplot remains 15 px.
Type of change