Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking release 0.22 #4477

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Breaking release 0.22 #4477

wants to merge 9 commits into from

Conversation

@ffreyer ffreyer added the breaking a PR with breaking changes label Oct 14, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 14, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.89s (4.82, 4.94) 0.04+- 123.49ms (117.72, 131.07) 4.43+- 372.61ms (368.67, 379.53) 4.37+- 9.61ms (9.31, 9.89) 0.23+- 26.53ms (26.37, 26.78) 0.15+-
master 5.33s (5.22, 5.44) 0.08+- 116.68ms (111.63, 142.79) 11.53+- 431.55ms (416.37, 459.25) 15.25+- 9.88ms (9.75, 10.12) 0.15+- 26.59ms (26.37, 26.79) 0.17+-
evaluation 1.09x faster✅, -0.44s (-6.70d, 0.00p, 0.06std) 0.94x noisy🤷‍♀️, 6.81ms (0.78d, 0.18p, 7.98std) 1.16x faster✅, -58.94ms (-5.26d, 0.00p, 9.81std) 1.03x faster ✓, -0.27ms (-1.38d, 0.03p, 0.19std) 1.00x invariant, -0.05ms (-0.34d, 0.54p, 0.16std)
CairoMakie 4.06s (4.03, 4.20) 0.06+- 115.92ms (114.76, 118.36) 1.37+- 389.07ms (384.24, 401.49) 6.46+- 9.36ms (9.28, 9.44) 0.06+- 1.18ms (1.17, 1.19) 0.01+-
master 4.80s (4.76, 4.95) 0.07+- 110.16ms (108.06, 115.54) 2.46+- 167.44ms (164.39, 172.31) 3.43+- 9.27ms (8.97, 9.48) 0.22+- 1.18ms (1.14, 1.21) 0.03+-
evaluation 1.18x faster✅, -0.74s (-11.40d, 0.00p, 0.06std) 0.95x slower X, 5.75ms (2.89d, 0.00p, 1.91std) 0.43x slower❌, 221.62ms (42.85d, 0.00p, 4.95std) 0.99x invariant, 0.09ms (0.53d, 0.35p, 0.14std) 1.00x invariant, 0.01ms (0.23d, 0.68p, 0.02std)
WGLMakie 4.50s (4.48, 4.51) 0.01+- 115.16ms (113.92, 115.99) 0.70+- 5.34s (5.16, 5.49) 0.13+- 12.18ms (11.76, 13.05) 0.41+- 135.03ms (123.36, 175.78) 18.11+-
master 5.30s (5.23, 5.32) 0.03+- 109.01ms (107.86, 109.80) 0.65+- 5.37s (5.32, 5.44) 0.04+- 12.05ms (11.94, 12.25) 0.10+- 128.21ms (120.93, 135.19) 5.25+-
evaluation 1.18x faster✅, -0.8s (-31.24d, 0.00p, 0.02std) 0.95x slower❌, 6.15ms (9.15d, 0.00p, 0.67std) 1.01x invariant, -0.03s (-0.35d, 0.54p, 0.09std) 0.99x invariant, 0.13ms (0.43d, 0.45p, 0.26std) 0.95x noisy🤷‍♀️, 6.82ms (0.51d, 0.37p, 11.68std)

ffreyer and others added 5 commits October 16, 2024 13:36
* get Makie to compile

* get GLMakie to compile

* fix  nromal rename, meshscatter

* fix pointtype in mesh conversion

* avoid matrix in vector rotation

* fix more tests

* update GeometryBasics functions/interface

* fix voronoiplot clipping

* update CairoMakie

* update RPRMakie

* prepare WGLMakie

* Update CI to use the GeometryBasics refactor branch (#4326)

* Update ci.yml

* Update Docs.yml

* Update reference_tests.yml

* add MeshIO branch

---------

Co-authored-by: ffreyer <frederic481994@hotmail.de>

* update _faces

* normals -> normal

* add ShaderAbstractions to ci

* update docs, normals deprecation

* fix branch names

* fix catmesh getting normals regenerated

* update for ShaderAbstractions

* handle voxel clipping in CairoMakie like in GLMakie

* fix another two "normals"

* add dev branches for RPRMakie CI

* fix missing kwarg name in conversion

* update for FaceViews

* add example for per-face colors and normals

* improve typing

* fix Sampler, allow mipmap via Sampler

* try to fix benchmarks

* add to correct env

* remove from master project

* fix docs

* fix Rect decomposition

* fix poly converts

* fix typo

* improve precompilation by avoiding constprop and more direct icon loading via PNGFiles

* fix CairoMakie precompile

* fix old syntax

* fix ambient light

* add temp dependencies to relocatbility test

* bump RPR to required version

* update changelog

* fix test

* fix other branch in ray cast test

* fix relocatability ci

* fix rpr and relocatability

---------

Co-authored-by: Anshul Singhvi <asinghvi17@simons-rock.edu>
Co-authored-by: SimonDanisch <sdanisch@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking a PR with breaking changes
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants