add backend and update_state kwargs to show #4558
Conversation
|
do any other also, i noticed that |
|
Thank you, seems reasonable!
Yeah why not :) |
bjarthur
force-pushed
the
bja/showbackend
branch
from
d405f8a
to
d610883
Compare
|
all i can think to test is for the presence of a ideally i'd like to test that specifying a different backend works, but that would require putting the test in one of the backend repos and adding a dependency to one of the other backends. you don't want to go that far, do you? |
bjarthur
force-pushed
the
bja/showbackend
branch
from
d610883
to
8ac3f36
Compare
|
ready for review |
|
the failed test on WGLMakie for julia 1.6 is a memory leak. is that related to this PR? |
bjarthur
changed the title
|
just added another kwarg to make reseting the axis limits optional when [EDIT: let me know if you'd prefer this to be in a separate PR] |
| @@ -244,17 +244,16 @@ function Base.show(io::IO, m::MIME"text/markdown", fig::FigureLike) | |||
| throw(MethodError(show, io, m, fig)) | |||
| end | |||
|
|
|||
| function Base.show(io::IO, m::MIME, figlike::FigureLike) | |||
| function Base.show(io::IO, m::MIME, figlike::FigureLike; backend = current_backend(), update_state=true) | |||
There was a problem hiding this comment.
I think just update would be better since that's what we use in display()
as discussed
showis the way to "save" a figure to an IOBuffer. but if the figure was made with say WGLMakie and you want to save as say PDF then it's a bit cumbersome because you have toCairoMakie.activate!and thenWGLMakie.activate!aftershowing. this PR make it more concise by adding abackendkwarg toshow, just likesavehas one already. so one can simplyshow(...; backend=CairoMakie)instead of activating and deactivating it.Type of change
Delete options that do not apply:
Checklist