Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function basemap to get a static image from Tyler, and some converts for image #91

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

asinghvi17
Copy link
Member

This file provides the ability to get static base maps from Tyler.

Its main entry point is the basemap function, which returns a tuple
(x, y, z) of the image data (z) and its axes (x and y). The image
is in a web-mercator CRS, we need to figure out a way to also get eg WGS84 tiles.

This file also contains definitions for convert_arguments that make
the following syntax "just work":

image(TileProviders.Google(), Rect2f(-0.0921, 51.5, 0.04, 0.025), (1000, 1000); axis= (; aspect = DataAspect()))

You do still have to provide the extent and image size, but this is substantially better than nothing.

@asinghvi17
Copy link
Member Author

asinghvi17 commented Jul 9, 2024

(This doesn't work now but will work with #90, since that imports FileIO)

@rafaqz
Copy link
Collaborator

rafaqz commented Jul 9, 2024

Is there a reason basemap isn't in MapTiles.jl ?

Would let other packages skip the Makie dep

@asinghvi17
Copy link
Member Author

HTTP.jl and ImageIO.jl are required to stitch the tiles together, but if those can go in MapTiles I'm fine to upstream this

@rafaqz
Copy link
Collaborator

rafaqz commented Jul 9, 2024

Ahh right. Might be worth it for Plots.jl uses

@asinghvi17
Copy link
Member Author

This will have to be reimplemented based off #95

@asinghvi17 asinghvi17 marked this pull request as draft August 3, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants