Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find and read personal commands recursively, allowing dirs #1228

Open
wants to merge 1 commit into
base: async
Choose a base branch
from
Open

Find and read personal commands recursively, allowing dirs #1228

wants to merge 1 commit into from

Conversation

jinnatar
Copy link
Contributor

This simplifies organisation and for example adding multiple upstream sources of commands as different directories or submodules.

Fully backwards compatible, assuming people aren't storing commands they don't want under a subdir of personal_commands.

@jinnatar
Copy link
Contributor Author

Friendly ping, anyone have an opportunity to review this?

@jinnatar jinnatar force-pushed the recursive_personal_commands branch from ab1fbd5 to 8ec61ef Compare July 17, 2022 13:10
@jinnatar
Copy link
Contributor Author

FYI, build failure is not due to this PR:

 flake8...................................................................Failed
  - hook id: flake8
  - exit code: 1
  
  mapadroid/ocr/pogoWindows.py:588:47: B023 Function definition does not bind loop variable 'thresh'.
  mapadroid/route/routecalc/calculate_route_quick.py:115:12: B020 Found for loop that reassigns the iterable it is iterating with each iterable value.

@jinnatar jinnatar force-pushed the recursive_personal_commands branch from 8ec61ef to 0e6153f Compare July 29, 2022 19:26
@jinnatar jinnatar force-pushed the recursive_personal_commands branch from 0e6153f to 8cde535 Compare March 18, 2023 12:00
@jinnatar jinnatar changed the base branch from legacy to async March 18, 2023 12:02
@jinnatar jinnatar force-pushed the recursive_personal_commands branch 2 times, most recently from 94cc755 to 1c5affc Compare March 18, 2023 12:17
@jinnatar
Use pathlib instead of glob for loading updater files
10f64da 
This allows for recursively loading personal_commands which enables
flexibility in distributing them as separate directories, for example
loading the ATV command library as as a submodule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jinnatar