Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New screen Limitations aka most likely better MAINTENANCE #1362

Merged
merged 7 commits into from
Sep 2, 2023

Conversation

JabLuszko
Copy link
Contributor

@JabLuszko JabLuszko commented Sep 1, 2023

Copy-paste code at this moment. If this turns out to be the old MAINTENANCE thing without any other side-effects we could streamline that in future and merge it into one, but for now copy-paste for faster debugging.

Default 24h cooldown, normal MAINTENANCE burnt procedure.

Also need different languages, but PokeMiners don't update language files anymore so DE/FR translation most welcome

@JabLuszko
Copy link
Contributor Author

JabLuszko commented Sep 2, 2023

Niantic seems to introduced some QOL changes and after failed login/maintenance hit (RETRY screen, it still does not show up live in-game) the username field is getting pre-filled/remembered across game restarts. MAD flow does not handle that and every login attempts it adds login again to already pre-filled login

Forcing cleaning game data/cache in RETRY screen - this means MAD will need OCR birthday again... but seems better choice then sending backspace 50 times on each login attempt or even worse detecting which (correct or older?) login is pre-filled there - so we won't end up like that https://discord.com/channels/465247740553592832/523602714244939787/1147526555136966726 :D

@JabLuszko
Copy link
Contributor Author

it still does not show up live in-game
Okey, this is a lie.

That screen shows up in-game so we probably could run screen OCR before Too many timeouts - Restarting game to see if it's MAINTENANCE and save on one game restart (to see RETRY screen)... but no idea if this is worth it

@Grennith
Copy link
Collaborator

Grennith commented Sep 2, 2023

Merging for now as a hotfix measurement. Will align/review code to integrate it via OCR in the next couple of days.

@Grennith Grennith merged commit adecbf5 into Map-A-Droid:async Sep 2, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants