Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route to map directly from strava #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hansonwj
Copy link

This pull request adds the functionality to allow an admin to configure rg2 to allow users to upload a recent activity directly from Strava and use them as route drawings. It makes it easier for users as they do not need to download the gpx file then reupload the file to rg2.

The configuration for admins is simple. Simply create a Strava API application and retrieve the application oAuth2 client and secret. Define STRAVA_CLIENT and STRAVA_SECRET in rg2-config.

If the oauth values are undefined, the user will not see the 'Get 10 most recent strava activities' button.

If defined, the user will see a button in the Draw tab which will allow them to sign in to strava via an oauth popup window, and the application will list their 10 most recent activities. They can then select one to add it to the map.


I did have to bodge the existing GET listener to accept the oauth code parameter. Can't see any way around this.

@Maprunner
Copy link
Owner

This is a really nice idea but I'm afraid I am not willing to merge it into the master branch.

Strava has a set of brand guidelines that you need to comply with when using their API. This implementation does not meet any of the mandatory requirements.

Even if it did, the Strava API Agreement looks much too restrictive and would potentially require a lot of extra work that I am not willing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants