Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt new version of livescan3d to mesh the point cloud #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhao-zilong
Copy link

Hi marek,

I changed the some of your code to adapt your new version of LiveScan3D, especially the part of library networkcommunication, I have tested the code, it works in my computer, but I think there is some bugs in the part of your new LiveScan3D, the sum of chunked triangles is always short of 1 than the number of lTriangles. and the indexs of triangles is just a part of vertices, because I tested that the biggest index of vertices in ITrianlges is 64998, but we have received more than 10 000 vertices.

so in order to not re-invented the wheels, I contribute my code here :)
Best regards

ZHAO ZILONG

@aviban
Copy link

aviban commented Nov 22, 2017

Hi Zhao,

Is there any changes at the transfer end also? As TrasferSocket.cpp seems a bit different. At the receiving end many new blocks are sent, did you modified anything at TransferSocket.cs or related files?
Just a little curious about it :)

Thanks and Regards,
Avinandan

@MarekKowalski
Copy link
Owner

Hi Avinandan,

Just to clear it up: this pull request would make the LiveScan3D-Hololens project compatible with this:
https://github.com/JacekNaruniec/LiveScan3D version of LiveScan3D, not the one that currently resides in the "official" repo.
That newer version of the app allows for mesh reconstruction, we plan to include it into the main repo at some points.

Marek

@aviban
Copy link

aviban commented Nov 24, 2017

Dear Marek,

Thanks a lot for your reply. I have downloaded the code from the link you have provided.
I will integrate the same to my existing setup.
Just want to check, if I need to also update the receiver end code for this?

Thanks Again,

Regards,
Avinandan

@zhao-zilong
Copy link
Author

zhao-zilong commented Nov 24, 2017

Hi Aviban,

I just saw your question, as Marek said, you use the server part in this link:
https://github.com/JacekNaruniec/LiveScan3D
and then you use the hololens part in my git, it will work, the new server will send the triangle index to holoens which can help to mesh the points. see this video of result:
https://youtu.be/qEYP9cEtZec

Best regards,

ZILONG

@aviban
Copy link

aviban commented Nov 25, 2017

Dear Zhao,

That's great. I am really excited to get involved in the work that you guys are doing. Its really amazing. Just waiting for the hololens to begin with. Meanwhile, just a small question. How many Kinect sensors you have used for the above shared video?

Thanks and Regards,
Avinandan

@aviban
Copy link

aviban commented Nov 25, 2017

Dear Marek,

LiveScan3D is really an amazing solution. For many of my friends, this solution is performing brilliantly over LAN. Just want to check that, are you looking for any up-gradation for Live 3D visualization over internet.

Thanks and Regards,
Avinandan

@MarekKowalski
Copy link
Owner

We have not tried it, but there is no reason why it should not work, the framerate will definitely be an issue though.

Marek

@aviban
Copy link

aviban commented Dec 6, 2017

Dear Zhao,

I am facing issues in rendering the 3D objects in Hololens. There is nothing I am able to view. Though
there is no problem in building and deploying. I think, probably some settings are different. If possible, can you please share your settings?

Thanks and Regards,
Avinandan

@zhao-zilong
Copy link
Author

zhao-zilong commented Dec 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants