Update streams objects to publicly expose underlying Subjects #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've exposed the underlying
Subject<T>
members in bothxxStreams
classes. This is because I want to be able to stream fake messages for testing my program which uses this library. Although that was already possible by using fakeIWebsocketClient
objects, that method is very clunky and requires that I send raw text instead of just POCO objects. There is no good reason for hiding theSubject<T>
members behindIObservable<T>
, so the most straight-forward way to enable easy testing is to just expose theSubject<T>
members directly.Summary of changes:
PrivateTrade
classIBitfinexPublicWebsocketClient
andIBitfinexAuthenticatedWebsocketClient
interfacesIBitfinexCommunicator
interface and implementation classLibLog
package reference withMicrosoft.Extensions.Logging.Abstractions
(asLigLog
is marked as deprecated)