Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common base class for ICryptoOrderBook implementations #13

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

shaynevanasperen
Copy link
Contributor

  • Fix bug in CryptoOrderBookL3PerformanceTests and tweak test parameters
  • Don't dispose the given IOrderBookSource

As requested by @Marfusios I am submitting smaller incremental pull requests to replace the big one I created earlier: #11

This is the first of them, and the changes here are a prerequisite for further changes that will come in future pull requests.

* Fix bug in CryptoOrderBookL3PerformanceTests and tweak test parameters
* Don't dispose the given IOrderBookSource
@Marfusios
Copy link
Owner

Thanks!

@Marfusios Marfusios merged commit 18fe560 into Marfusios:master Apr 29, 2024
2 checks passed
@shaynevanasperen shaynevanasperen deleted the refactor branch July 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants