Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill disregards strokestyle #38

Merged

Conversation

CodeGod911
Copy link
Contributor

sry to bother again but i didnt notice the whole afternoon :)
grafik

@MarvinKlein1508
Copy link
Owner

Can you clarify how I can reproduce? For me it works fine.

@CodeGod911 CodeGod911 marked this pull request as draft July 2, 2024 16:59
@CodeGod911
Copy link
Contributor Author

its just perfect dots so stay absolutely still and click then draw around. but i noticed something else ill look into it closer

@CodeGod911
Copy link
Contributor Author

i dont quite like this rectangle dot but i think its a limitation of the canvas in the BG Demo
grafik
Much better in Options Demo
grafik

@CodeGod911 CodeGod911 closed this Jul 2, 2024
@CodeGod911 CodeGod911 reopened this Jul 2, 2024
@CodeGod911 CodeGod911 marked this pull request as ready for review July 2, 2024 17:43
@MarvinKlein1508 MarvinKlein1508 self-requested a review July 2, 2024 20:00
@CodeGod911 CodeGod911 marked this pull request as draft July 2, 2024 22:02
@CodeGod911
Copy link
Contributor Author

There is actually a huge issue not clearing before redrawing because the last points differ in calculation on slower devices this results in very bad artifacts
grafik

@CodeGod911
Copy link
Contributor Author

this fix looks much better at the cost of being 1 frame behind while drawing which i think is acceptable
grafik

@CodeGod911 CodeGod911 marked this pull request as ready for review July 3, 2024 06:04
Copy link
Owner

@MarvinKlein1508 MarvinKlein1508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarvinKlein1508 MarvinKlein1508 merged commit bb1c62d into MarvinKlein1508:master Jul 3, 2024
1 check failed
@MarvinKlein1508 MarvinKlein1508 deleted the bugfix/ColorOfDots branch July 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants