Merge pull request #857 from felipehertzer/2.0

MySQL Close cursor and connection on commit
MasoniteFramework · Sep 30, 2023 · 1adac4b · 1adac4b
2 parents d9c8e13 + 5d47746
commit 1adac4b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/masoniteorm/connections/MySQLConnection.py b/src/masoniteorm/connections/MySQLConnection.py
@@ -105,6 +105,9 @@ def commit(self):
         """Transaction"""
         self._connection.commit()
         self.transaction_level -= 1
+        if self.get_transaction_level() <= 0:
+            self.open = 0
+            self._connection.close()
 
     def dry(self):
         """Transaction"""
@@ -169,6 +172,7 @@ def query(self, query, bindings=(), results="*"):
         except Exception as e:
             raise QueryException(str(e)) from e
         finally:
+            self._cursor.close()
             if self.get_transaction_level() <= 0:
                 self.open = 0
                 self._connection.close()