-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPBergsma/partial data #1812
base: 0.25.x
Are you sure you want to change the base?
JPBergsma/partial data #1812
Conversation
This reverts commit 6251e48.
This reverts commit bf9692a.
…/optimade-python-tools into JPBergsma/add_metadata
774cbc5
to
2f76149
Compare
2f76149
to
3be7d54
Compare
b1b66c4
to
075ef06
Compare
removed duplicate requirement
* Use Python 3.9 as the 'base' CI version for linting * Update pre-commit hooks * Run `pyupgrade --py39-plus` to upgrade legacy annotations * Add `--exit-non-zero-on-fix` for ruff Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> * Use f-string over format Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> --------- Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
7cca9c5
to
bf29459
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.25.x #1812 +/- ##
==========================================
- Coverage 90.77% 90.65% -0.12%
==========================================
Files 74 78 +4
Lines 4629 4956 +327
==========================================
+ Hits 4202 4493 +291
- Misses 427 463 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @JPBergsma, I've just changed the base branch of this PR and others to the new 0.25.x branch until we can port things over. I would suggest you keep working as you see fit, and we can then try to port your changes over to the new format once finished. |
PR to implement the partial data mechanism and the JSON lines return format as described in PR#467, and PR#481