Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect package set flake input #274

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Indirect package set flake input #274

merged 2 commits into from
Sep 20, 2024

Conversation

brynblack
Copy link
Member

@brynblack brynblack commented Sep 4, 2024

Description

This PR incorporates the new indirect flake input system.

Tasks

  • 1. Update flake.nix to use indirect inputs
  • 2. Remove -dirty from revision string

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@brynblack brynblack self-assigned this Sep 6, 2024
@brynblack brynblack force-pushed the feature-flake-indirect branch 3 times, most recently from e31f308 to d82fec5 Compare September 18, 2024 03:46
@CMCDragonkai
Copy link
Member

What's blocking this from merge?

@brynblack brynblack merged commit 806339e into staging Sep 20, 2024
38 of 39 checks passed
@CMCDragonkai
Copy link
Member

Hey @brynblack don't do tag releases from branches. They are only allowed from staging branch.

@CMCDragonkai
Copy link
Member

It might even break something.

@tegefaulkes please check that this works.

@tegefaulkes
Copy link
Contributor

We went over it already. It's already fixed and I explained the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants