Allow vault efs resource acquisition to operate on multiple vaults in parallel
#847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For handlers like
VaultsSecretsCopyandVaultsSecretsMove, we need to acquire a transaction across multiple vaults. This allows for all the given operations to be completed in a single transaction, avoiding polluting the commit space.This PR creates such pattern, to acquire the resources from a vault dynamically in a way which works across multiple vaults at the same time.
Issues Fixed
VaultsSecretsRemoveincorrectly reorders directories to be removed #837 (FIX ENG-450)Tasks
VaultInternal.acquireReadVaultInternal.acquireWriteVaultsSecretsRemoveto use this instead of grouping paths by vault name.Final checklist