don't export the CRC32 table

It was not exported properly when building a DLL. We it's not necessary for other classes. It can be restrictued to that C++ compilation unit that noone else will see.
Matroska-Org · Dec 28, 2023 · b4b56a6 · b4b56a6
1 parent 83a710b
commit b4b56a6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/ebml/EbmlCrc32.h b/ebml/EbmlCrc32.h
@@ -61,7 +61,6 @@ DECLARE_EBML_BINARY(EbmlCrc32)
     void ResetCRC();
     void UpdateByte(binary b);
 
-    static const std::array<std::uint32_t, 256> m_tab;
     std::uint32_t m_crc;
     std::uint32_t m_crc_final{0};
 

diff --git a/src/EbmlCrc32.cpp b/src/EbmlCrc32.cpp
@@ -27,7 +27,7 @@ namespace libebml {
 
 DEFINE_EBML_CLASS_GLOBAL(EbmlCrc32, 0xBF, 1, "EBMLCrc32\0ratamadabapa")
 
-constexpr std::array<std::uint32_t, 256> EbmlCrc32::m_tab {
+static constexpr std::array<std::uint32_t, 256> m_tab {
 #ifdef WORDS_BIGENDIAN
   0x00000000L, 0x96300777L, 0x2c610eeeL, 0xba510999L, 0x19c46d07L,
   0x8ff46a70L, 0x35a563e9L, 0xa395649eL, 0x3288db0eL, 0xa4b8dc79L,