don't keep null clones

This will crash in the destructor and many other places. It's unlikely to happen by better safe than sorry.
Matroska-Org · Dec 18, 2023 · c1788f5 · c1788f5
1 parent 3ca96d4
commit c1788f5
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/EbmlMaster.cpp b/src/EbmlMaster.cpp
@@ -61,7 +61,11 @@ EbmlMaster::EbmlMaster(const EbmlMaster & ElementToClone)
   ElementList.reserve(ElementToClone.ListSize());
   // add a clone of the list
   for (const auto& e : ElementToClone.ElementList)
-    ElementList.push_back(e->Clone());
+  {
+    auto *clone = e->Clone();
+    if (clone != nullptr)
+      ElementList.push_back(clone);
+  }
 }
 
 EbmlMaster::~EbmlMaster()