don't try to write elements that are deprecated

They should not be readable by anyone.
Matroska-Org · Jan 28, 2024 · efd91a8 · efd91a8
1 parent d369800
commit efd91a8
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/ebml/EbmlElement.h b/ebml/EbmlElement.h
@@ -454,11 +454,12 @@ class EBML_DLL_API EbmlElement {
     static bool WriteSkipDefault(const EbmlElement &elt) {
       if (elt.IsDefaultValue())
         return false;
-      return true;
+      return !elt.ElementSpec().GetVersions().IsAlwaysDeprecated();
     }
 
-    static bool WriteAll(const EbmlElement &) {
-      return true;
+    // write all elements except deprecated ones
+    static bool WriteAll(const EbmlElement & elt) {
+      return !elt.ElementSpec().GetVersions().IsAlwaysDeprecated();
     }
 
     explicit EbmlElement(const EbmlCallbacks &, std::uint64_t aDefaultSize, bool bValueSet = false);