Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a callback to select which element are written #173

Merged
merged 4 commits into from
Dec 28, 2023
Merged

Add a callback to select which element are written #173

merged 4 commits into from
Dec 28, 2023

Commits on Dec 28, 2023

  1. Use a callback to select which elements should be written 

    This is more flexible than a flag that applies to all the elements inside a Master.
It can now be filtered by element, based on their ID, position, profile, etc.

A EBML_WRITE_FILTER define is added to be able to check libmatroska 2.0
with this feature or not.
    @robUx4
    robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    91ce3ec View commit details
    Browse the repository at this point in the history

  2. remove ForceNoDefault() 

    This is a hack to pretend an element doesn't have its default value
so it ends up being written.
    @robUx4
    robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    213380d View commit details
    Browse the repository at this point in the history

  3. use std::function as callback for ShouldWrite

    @mbunkus @robUx4
    mbunkus authored and robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    0391375 View commit details
    Browse the repository at this point in the history

  4. avoid "unused variable" warnings

    @mbunkus @robUx4
    mbunkus authored and robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    8b6c24e View commit details
    Browse the repository at this point in the history