Rework UTFString API to only keep UTF-8 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to know about many UCS2 characters are in a string, Matroska is using UTF-8.
The internal std::string and std::wstring will be handled automatically.
robUx4
added
api-break
Matroska only deals with UTF-8. The only reason to use wchar_t is when converting to/from host strings that are not in UTF-8 (usually Windows). And we only need the conversion in one way. This will avoid plenty of uneeded conversions when only dealing with UTF-8.
If the string buffer comes from an EBML file we should be able to copy the same buffer without interpreting it, even if it's bogus. It may be intentional. Fixes Matroska-Org#180
In C++20 it would use char8_t.
mbunkus
approved these changes
Dec 26, 2023
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Dec 28, 2023
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In EBML and in most systems, UTF-8 is used by default. Converting from wchar_t should be the exception and not done for every unicode string we read/write.
Some API's with wchar_t are gone. They are not used in VLC (which just deals wtih UTF-8) and in some corresponding
to_widefunctions in mkvtoolnix seem to be unused and can also be removed.The length() reported is different. It now reports the length in bytes of the UTF-8 string which is the length needed to write the buffer in EBML anyway.
This PR also fixes #180.