Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused types and cleanup namespace usage #185

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Remove some unused types and cleanup namespace usage #185

merged 4 commits into from
Dec 27, 2023

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 26, 2023

No description provided.

@robUx4
remove unused basic types
287e064 
New code should use the regular types directly.
@robUx4
move the open_mode enum in the libebml namespace
95db490 
It's only used for StdIOCallback.
@robUx4
move libebml API types in the libebml namespace
676d914
@robUx4
remove libebml namespace macros
8b71e50 
Noone is using them and libebml using should know what namespace to use if they know
what macro to use.
@robUx4 robUx4 added the api-break breaks the API (e.g. programs using it will have to adjust their source code) label Dec 26, 2023
@robUx4 robUx4 requested a review from mbunkus December 26, 2023 10:12
@robUx4 robUx4 merged commit 17016d7 into Matroska-Org:master Dec 27, 2023
20 checks passed
@robUx4 robUx4 deleted the basic_types branch December 27, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus