Use macros to define global context and make all semantic constexpr #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbunkus
approved these changes
Dec 28, 2023
The extern one was never exported properly. So it's not part of the public API.
The macro was turning it into something that is not its declaration. The other extern are also using the wrong name but noone uses them.
DEFINE_xxx_MASTER_ORPHAN is not constexpr because Context_EbmlHead needs to be exported.
robUx4
force-pushed
the
macros_global
branch
from
9baceea
to
178f343
Compare
mbunkus
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.