Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the usage of temporary EbmlDocVersion instances to init global semantic classes #228

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Keep the usage of temporary EbmlDocVersion instances to init global semantic classes #228

merged 5 commits into from
Jan 28, 2024

Commits on Jan 28, 2024

  1. make the element spec a constexpr

    @robUx4
    robUx4 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5815ea7 View commit details
    Browse the repository at this point in the history

  2. make the EbmlId definitions static 

    They can be accessed though the EbmlCallbacks of the given class.
This allows passing it in another constexpr constructor.
    @robUx4
    robUx4 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    e158423 View commit details
    Browse the repository at this point in the history

  3. fix passing temporary EbmlDocVersion as versioning values

    @robUx4
    robUx4 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    87a5aec View commit details
    Browse the repository at this point in the history

  4. store the info about having a default values in EbmlCallbacks 

    So it doesn't have to be a virtual class anymore and can be a real static constexp.
    @robUx4
    robUx4 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5529b1e View commit details
    Browse the repository at this point in the history

  5. add test for version handling

    @robUx4
    robUx4 committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    ff49764 View commit details
    Browse the repository at this point in the history