Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declare EbmlDummy constructor in cpp file #237

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Jan 31, 2024

Fixes compilation on GCC7-9 for some reason.

Fixes compilation on GCC7-9 for some reason.
@neheb
Copy link
Contributor Author

neheb commented Feb 1, 2024

This was probably introduced with 8441376

@robUx4
Copy link
Contributor

robUx4 commented Feb 1, 2024

What is the compilation error ? The code is strictly the same. If there's an include missing we should add it.

@neheb
Copy link
Contributor Author

neheb commented Feb 1, 2024

It’s a linker error. It can’t figure out where to place the class for some reason.

@neheb
Copy link
Contributor Author

neheb commented Feb 1, 2024

#233 (comment)

@neheb
Copy link
Contributor Author

neheb commented Feb 2, 2024

ChatGPT's reaction:

The reason for this fix might be related to how templates and inline functions are handled across different GCC versions. Some older versions of GCC might have difficulty with certain constructs, and moving the implementation of the constructor from the header to the cpp file can resolve these issues.

Without more specific details about the linker error or the GCC version in question, it's challenging to pinpoint the exact reason. However, the common practice of moving constructor implementations from header files to cpp files is often used to address such issues with template and inline code across different compiler versions.

@mbunkus mbunkus merged commit 4c19701 into Matroska-Org:master Feb 2, 2024
15 checks passed
@neheb neheb deleted the cl branch February 4, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants