Turn main EBML macros into static inlines #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
robUx4
force-pushed
the
ebml_macros
branch
3 times, most recently
from
7436d75
to
274d83c
Compare
|
Unfortunately this breaks any chance of having a code base compile with both libEBML < 2 and >= 2. I'll have to re-add all the macros back in MKVToolNix for as long as I want to support both. I'll hold off on testing this PR for the time being. |
robUx4
force-pushed
the
ebml_macros
branch
2 times, most recently
from
723355c
to
4fdf0b2
Compare
|
@mbunkus I updated the MR to keep the existing macros, they redirect to the typed functions. |
So we have stronger typing and a better sense of the input type. Put the "macros" right after the input type declaration they are associated with.
mbunkus
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have stronger typing and have the better idea of how they should be called.
Once downside is that they are not grouped together anymore.
Depends on #265