Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework element creation #289

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Rework element creation #289

wants to merge 5 commits into from

Commits on Mar 4, 2024

  1. make CreateElement non virtual 

    In all cases we were creating an element with the empty constructor.
This is available via the EbmlCallbacks.
    @robUx4
    robUx4 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    deaa7b4 View commit details
    Browse the repository at this point in the history

  2. define EBML_SEM_CREATE using other macros 

    We don't need a specific function for that.
    @robUx4
    robUx4 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    a84eeb1 View commit details
    Browse the repository at this point in the history

  3. remove EbmlSemantic::Create() 

    EBML_SEM_CREATE should be used instead
    @robUx4
    robUx4 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    3e29362 View commit details
    Browse the repository at this point in the history

  4. add a helper macro to get the spec of an EbmlElement 

    i.e. it EbmlCallbacks
    @robUx4
    robUx4 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6f872d1 View commit details
    Browse the repository at this point in the history

  5. add a macro to replace CreateElement

    @robUx4
    robUx4 committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5d65d17 View commit details
    Browse the repository at this point in the history