Revert "Make more use of typed children macros and remove FindElt" #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did the merge request that is needed for the original PR and updated it again. Please test with that so we can bring this cleaner code back. |
|
Ah… uhm… I'm a bit confused 😂 Which PR should I check out? |
|
The "typed children" one: https://gitlab.com/mbunkus/mkvtoolnix/-/merge_requests/2257 |
|
It probably doesn't change much regarding segfaults as its mostly for compilation. But I'm pretty sure the code changes are solid, so it's weird if it still crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #285
Unfortunately I merged to soon: many segfaults in MKVToolNix. Haven't debugged it yet.