store the info about having a default values in EbmlCallbacks #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbunkus
requested changes
Jan 28, 2024
There was a problem hiding this comment.
Fails to build with current libEBML/libMatroska master:
lib/libmatroska/src/KaxSemantic.cpp:144:1: fatal error: constexpr variable cannot have non-literal type 'const libebml::EbmlCallbacks'
DEFINE_MKX_BINARY_CONS(KaxSimpleBlock, 0xA3, 1, KaxCluster, "SimpleBlock", VERSION_SINCE_V2)
^
lib/libmatroska/matroska/KaxDefines.h:48:47: note: expanded from macro 'DEFINE_MKX_BINARY_CONS'
constexpr const libebml::EbmlCallbacks a::ClassInfos(a::Create, Id_##a, false, false, e, Context_##a, versions);
^
lib/libebml/ebml/EbmlElement.h:333:13: note: 'EbmlCallbacks' is not literal because it has a non-trivial destructor
virtual ~EbmlCallbacks() = default;
^
lib/libebml/ebml/EbmlElement.h:333:13: note: destructor for 'EbmlCallbacks' is not trivial because it is virtual
clang++ 16
|
It is expected to fail to build without Matroska-Org/libebml#228. |
robUx4
force-pushed
the
callbacks_init_fix
branch
from
bddaa21
to
2e5a86b
Compare
So it doesn't have to be a virtual class anymore and can be a real static constexp.
robUx4
force-pushed
the
callbacks_init_fix
branch
from
2e5a86b
to
67a8ada
Compare
mbunkus
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it doesn't have to be a virtual class anymore and can be a real static constexp.
Necessary to build libmatroska with Matroska-Org/libebml#228.