do not export Context_xxx of master elements #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
It gives the same type, but EBML_CLASS_CONTEXT is more generic and doesn't need the Context_xx to be exported.
It can be retrieved with EBML_CLASS_CONTEXT(), no need to specifically export them from DLLs. Neither mkvtoolnix nor VLC use these, apart from Context_KaxMatroska, which doesn't have a definition outside of here.
robUx4
force-pushed
the
no_Context_export
branch
from
3efdb05
to
adeefef
Compare
mbunkus
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be retrieved with EBML_CLASS_CONTEXT(), no need to specifically export them from DLLs.
Neither mkvtoolnix nor VLC use these, apart from Context_KaxMatroska,
which doesn't have a definition outside of here.
More radical approach than #183