[1.x] use a single enum for the Chapter Codec IDs #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teCodec They must have the same values as MatroskaChapProcessCodecID. No need for 3 enums for the same type.
robUx4
added
the
abi-break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how RFC 9559 defines the value.
The
MatroskaChapProcessCodecIDwas missing.This is breaking the API (not the ABI) but I doubt anyone is using these (recent from #67) enum values.
I can add some
using MatroskaChapterTranslateCodec = MatroskaChapProcessCodecID;if needed and also define the old names to the new name if needed.