fix: throwing the errors instead of returning them (#138)

src/events/channels.service.ts

@@ -1,8 +1,4 @@
-import {
-  ForbiddenException,
-  Injectable,
-  NotFoundException,
-} from '@nestjs/common';
+import { Injectable } from '@nestjs/common';
 import { ChannelsService } from 'src/channels/channels.service';
 import { ChannelDeletedDto } from './dto/channel-deleted.dto';
 import { EventReplyDto } from './dto/event-reply.dto';
@@ -114,28 +110,6 @@ export class ChannelsEventService {
       payload.data,
     );
 
-    if (result instanceof NotFoundException) {
-      return {
-        status: 'FAILED',
-        error: {
-          id: '404',
-          message: 'Not Found',
-        },
-        seq_reply: payload.seq,
-      };
-    }
-
-    if (result instanceof ForbiddenException) {
-      return {
-        status: 'FAILED',
-        error: {
-          id: '403',
-          message: 'Forbidden',
-        },
-        seq_reply: payload.seq,
-      };
-    }
-
     if (!result) {
       return {
         status: 'FAILED',

src/workspace-channel/workspace-channel.service.ts

@@ -30,10 +30,10 @@ export class WorkspaceChannelService {
   ) {
     const channel = await this.channelsService.getChannelById(user, channelId);
     if (!channel) {
-      return new NotFoundException();
+      throw new NotFoundException();
     }
     if (channel.owner.id !== user.id) {
-      return new ForbiddenException();
+      throw new ForbiddenException();
     }
 
     const usersToAdd = await this.getWorkspaceMembers(data.users, workspaceId);

src/workspaces/workspaces.service.ts

@@ -43,7 +43,7 @@ export class WorkspacesService {
   async getWorkspace(id: Workspace['id']) {
     const workspace = await this.workspaceRepository.findOne({ id });
     if (!workspace) {
-      return new NotFoundException();
+      throw new NotFoundException();
     }
     return workspace;
   }